syntax-check: add syntactic rule to prohibit gs_strfreev

and fix an instance.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

diff --git a/maint.mk b/maint.mk
index 9b77357075df322f96b4eddd047ece847e6c1be2..8cda1ada44894ba1cfe021bcf181cadd19f5eb23 100644 (file)
--- a/maint.mk
+++ b/maint.mk
@@ -1032,6 +1032,11 @@ sc_const_long_option:
        halt='add "const" to the above declarations'                    \
          $(_sc_search_regexp)
 
+sc_prohibit_gs_strfreev:
+       @prohibit='\bgs_strfreev\b' \
+       halt="do not use gs_strfreev; use g_autoptr instead"            \
+         $(_sc_search_regexp)
+
 sc_prohibit_gs_unref:
        @prohibit='\bgs_unref_(keyfile|variant*|ptrarray|hashtable|bytes|object)\b' \
        halt="do not use gs_unref_*; use g_autoptr instead"             \

diff --git a/src/libostree/ostree-core.c b/src/libostree/ostree-core.c
index f779f89e22c0e1a01840c121929db80b171a4e4d..88dcf6458c73a71746d4596f66977261bafc4684 100644 (file)
--- a/src/libostree/ostree-core.c
+++ b/src/libostree/ostree-core.c
@@ -1501,7 +1501,7 @@ _ostree_parse_delta_name (const char  *delta_name,
                           char        **out_from,
                           char        **out_to)
 {
-  gs_strfreev char **parts = g_strsplit (delta_name, "-", 2);
+  g_auto(GStrv) parts = g_strsplit (delta_name, "-", 2);
 
   *out_from = *out_to = NULL;
   if (parts[0] && parts[1])